fix(fab-buttons): vertically align icons inside fab buttons #8442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added `.mat-fab` & `.mat-mini-fab`to the vertical align definition of buttons
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 14, 2017
| @@ -51,7 +51,7 @@ | |||
| } | |||
|
|
|||
| // The text and icon should be vertical aligned inside a button | |||
| .mat-button, .mat-raised-button, .mat-icon-button { | |||
| .mat-button, .mat-raised-button, .mat-icon-button, .mat-fab, .mat-mini-fab { | |||
There was a problem hiding this comment.
Does this change the color in any circumstances?
There was a problem hiding this comment.
in mat-icon css there's fill: currentColor;
which means that it always should be the currentColor.. from my tests it doesn't affect the color of the or the text in a fab button
jelbourn
added
merge: caretaker note
|
Caretaker note: do a global run for this one, be on the lookout for screenshot failures |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.mat-fab&.mat-mini-fabto the vertical align definition of buttons