fix(overlay): better handling of server-side rendering #8422
Conversation
googlebot
added
the
cla: yes
src/cdk/a11y/live-announcer.ts
Outdated
| @@ -14,7 +14,7 @@ import { | |||
| SkipSelf, | |||
| OnDestroy, | |||
| } from '@angular/core'; | |||
| import {Platform} from '@angular/cdk/platform'; | |||
| import {DOCUMENT} from '@angular/platform-browser'; | |||
There was a problem hiding this comment.
The DOCUMENT from platform-browser is deprecated; should use the one from @angular/common instead
| // causes TypeScript to preserve the constructor signature types. | ||
| this._liveElement = elementToken || this._createLiveElement(); | ||
| } | ||
| @Inject(DOCUMENT) private _document: any) { |
There was a problem hiding this comment.
I think you can do:
@Inject(DOCUMENT) private _document: Document|DocumentIt shouldn't preserve the type info for "computed" types; I think this will trick it will still giving type safety
There was a problem hiding this comment.
That doesn't seem to work in AoT.
| deps: [[new Optional(), new SkipSelf(), OverlayKeyboardDispatcher]], | ||
| deps: [ | ||
| [new Optional(), new SkipSelf(), OverlayKeyboardDispatcher], | ||
| DOCUMENT as InjectionToken<any> // We need to use the InjectionToken somewhere to keep TS happy |
There was a problem hiding this comment.
// Coerce to `InjectionToken` so that the `deps` match the "shape"
// of the type expected by Angular| element.parentNode.insertBefore(this._wrapper, element); | ||
| this._wrapper.appendChild(element); | ||
| this._wrapper = this._document.createElement('div'); | ||
| this._wrapper!.classList.add('cdk-global-overlay-wrapper'); |
There was a problem hiding this comment.
Put the ! on the assignment for _wrapper?
this._wrapper = this._document.createElement('div')!;There was a problem hiding this comment.
TS can't figure it out when assigning to a property.
Fixes multiple server-side rendering issues in the overlay that were causing errors when an overlay is opened in Universal. Fixes angular#8412.
crisbeto
force-pushed
the
8412/overlay-ssr
branch
from
c24e05d
to
24492be
Compare
|
Addressed the feedback @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes multiple server-side rendering issues in the overlay that were causing errors when an overlay is opened in Universal.
Fixes #8412.