Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatSlideToggle without label is default styled such that it does not center correctly #8264

Closed
Jaarx opened this issue Nov 7, 2017 · 1 comment · Fixed by #8270
Closed

MatSlideToggle without label is default styled such that it does not center correctly #8264

Jaarx opened this issue Nov 7, 2017 · 1 comment · Fixed by #8270
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@Jaarx
Copy link

Jaarx commented Nov 7, 2017

Bug, feature request, or proposal:

Default CSS for MatSlideToggle doesn't keep it vertically centered if it doesn't have label text and if it's a child of a flex-displayed element.

What are the steps to reproduce?

http://plnkr.co/edit/QTqBwfPb4oZrqvvau8nI?p=preview
@crisbeto crisbeto self-assigned this Nov 7, 2017
@crisbeto crisbeto added the has pr label Nov 7, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 7, 2017
@crisbeto
fix(slide-toggle): height collapsing if component doesn't have a label
d2aafa2 
Fixes the slide label component collapsing down to 16px if it doesn't have a label.

Fixes angular#8264.
@crisbeto crisbeto mentioned this issue Nov 7, 2017
Merged
jelbourn pushed a commit that referenced this issue Nov 18, 2017
@crisbeto @jelbourn
fix(slide-toggle): height collapsing if component doesn't have a label
6003c9b 
Fixes the slide label component collapsing down to 16px if it doesn't have a label.

Fixes #8264.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 19, 2017
@crisbeto
fix(slide-toggle): height collapsing if component doesn't have a label
77ef20d 
Fixes the slide label component collapsing down to 16px if it doesn't have a label.

Fixes angular#8264.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 20, 2017
@crisbeto
fix(slide-toggle): height collapsing if component doesn't have a label
33dd94b 
Fixes the slide label component collapsing down to 16px if it doesn't have a label.

Fixes angular#8264.
@crisbeto crisbeto added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Nov 28, 2017
tinayuangao pushed a commit that referenced this issue Nov 29, 2017
@crisbeto @tinayuangao
fix(slide-toggle): height collapsing if component doesn't have a label (
8205cb2 
#8270)

Fixes the slide label component collapsing down to 16px if it doesn't have a label.

Fixes #8264.
tinayuangao pushed a commit to tinayuangao/material2 that referenced this issue Nov 29, 2017
@crisbeto @tinayuangao
fix(slide-toggle): height collapsing if component doesn't have a label (
69f9baa 
angular#8270)

Fixes the slide label component collapsing down to 16px if it doesn't have a label.

Fixes angular#8264.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(slide-toggle): height collapsing if component doesn't have a label crisbeto/material2
2 participants
@Jaarx @crisbeto