fix(spinner): set initial value for spinner to 0 #8139

josephperrott · 2017-10-30T22:53:51Z

jelbourn

LGTM, will wait for @crisbeto to chime in since there may be an implication here I'm not thinking of

jelbourn · 2017-10-30T23:01:32Z

src/lib/progress-spinner/progress-spinner.spec.ts

@@ -4,7 +4,7 @@ import {By} from '@angular/platform-browser';
 import {MatProgressSpinnerModule} from './index';


-describe('MatProgressSpinner', () => {
+fdescribe('MatProgressSpinner', () => {


fdescribe

crisbeto

LGTM

angular-automatic-lock-bot · 2019-09-07T14:02:26Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

josephperrott added the pr: needs review label Oct 30, 2017

josephperrott requested review from crisbeto and andrewseguin October 30, 2017 22:53

josephperrott requested a review from jelbourn as a code owner October 30, 2017 22:53

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 30, 2017

jelbourn approved these changes Oct 30, 2017

View reviewed changes

josephperrott force-pushed the spinner branch from dbd5817 to e222390 Compare October 30, 2017 23:05

Set initial value for spinner to 0.

140264b

josephperrott force-pushed the spinner branch from e222390 to 140264b Compare October 31, 2017 17:49

crisbeto approved these changes Oct 31, 2017

View reviewed changes

crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 31, 2017

andrewseguin merged commit 9e4c636 into angular:master Nov 2, 2017

josephperrott deleted the spinner branch November 10, 2017 19:33

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(spinner): set initial value for spinner to 0 #8139

fix(spinner): set initial value for spinner to 0 #8139

josephperrott commented Oct 30, 2017

jelbourn left a comment

jelbourn Oct 30, 2017

crisbeto left a comment

angular-automatic-lock-bot bot commented Sep 7, 2019

fix(spinner): set initial value for spinner to 0 #8139

fix(spinner): set initial value for spinner to 0 #8139

Conversation

josephperrott commented Oct 30, 2017

jelbourn left a comment

Choose a reason for hiding this comment

jelbourn Oct 30, 2017

Choose a reason for hiding this comment

crisbeto left a comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 7, 2019