fix(block-scroll-strategy): disable smooth scrolling before restoring scroll position #8132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
7139/block-scroll-smooth
branch
from
798b9ab
to
a229b1a
Compare
jelbourn
reviewed
Oct 30, 2017
| @@ -45,11 +45,25 @@ export class BlockScrollStrategy implements ScrollStrategy { | |||
| /** Unblocks page-level scroll while the attached overlay is open. */ | |||
| disable() { | |||
| if (this._isEnabled) { | |||
| const html = document.documentElement; | |||
| const body = document.body; | |||
| const previousHTMLScrollBehavior = html.style['scrollBehavior'] || ''; | |||
| const root = document.documentElement; | ||
| const body = document.body; | ||
|
|
||
| root.style['scrollBehavior'] = body.style['scrollBehavior'] = 'smooth'; |
There was a problem hiding this comment.
Need to reset this after the test?
… scroll position Disables user-defined `scroll-behavior: smooth` before restoring the scroll position when disabling the `BlockScrollStrategy`, which prevents browsers from animating the scroll position change. Fixes angular#7139.
crisbeto
force-pushed
the
7139/block-scroll-smooth
branch
from
a229b1a
to
7688de0
Compare
|
Addressed the feedback @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables user-defined
scroll-behavior: smoothbefore restoring the scroll position when disabling theBlockScrollStrategy, which prevents browsers from animating the scroll position change.Fixes #7139.