fix(table): render cells even if data is falsy #7914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
andrewseguin
added
pr: needs review
and removed
cla: yes
josephperrott
added
pr: lgtm
action: merge
andrewseguin
added
the
P1
jelbourn
reviewed
Oct 20, 2017
| const cells = rowData ? this._getCellTemplatesForRow(row) : []; | ||
|
|
||
| cells.forEach(cell => { | ||
| this._getCellTemplatesForRow(row).forEach(cell => { |
googlebot
added
the
cla: yes
|
Added a unit test |
jelbourn
reviewed
Oct 21, 2017
src/cdk/table/table.spec.ts
Outdated
| </cdk-table> | ||
| ` | ||
| }) | ||
| class EvenSimplerCdkTableApp { |
There was a problem hiding this comment.
TableWithBooleanDataSource?
("EvenSimpler" doesn't tell you anything really)
jelbourn
reviewed
Oct 23, 2017
src/cdk/table/table.spec.ts
Outdated
| @@ -109,10 +109,10 @@ describe('CdkTable', () => { | |||
| }); | |||
|
|
|||
| it('should render cells even if row data is falsy', () => { | |||
| const evenSimplerCdkTableAppFixture = TestBed.createComponent(EvenSimplerCdkTableApp); | |||
| const booleanRowCdkTableAppFixture = TestBed.createComponent(EvenSimplerCdkTableApp); | |||
There was a problem hiding this comment.
Name of the component too?
EvenSimplerCdkTableApp -> TableWithBooleanDataSource
There was a problem hiding this comment.
d'oh yes - my brain was thinking they were all renaming
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an optimization assuming that undefined data was meant to create a row without cells. This is a faulty design decision and the logic is incorrect anyways (see issue,
0and other falsy values caused empty rows).Supported workaround to rendering empty rows is to use the
whenpredicate that can define a row without columns.Fixes #7902