Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datepicker): correct DST issues on IE 11 #7858

Merged
merged 2 commits into from
Nov 7, 2017
Merged

fix(datepicker): correct DST issues on IE 11 #7858

merged 2 commits into from
Nov 7, 2017

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Oct 17, 2017 •
edited
Loading

fixes #7167
fixes #8228

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 17, 2017
@mmalerba
Copy link
Contributor Author

demo: https://mmalerba-demo1.firebaseapp.com/datepicker

crisbeto
crisbeto reviewed Oct 17, 2017
View reviewed changes
src/lib/core/datetime/native-date-adapter.ts
super.setLocale(matDateLocale);

// IE does its own time zone correction, so we disable this on IE.
this.useUtcForDisplay = !platform.TRIDENT;
Copy link
Member

@crisbeto crisbeto Oct 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can this be feature-detected (e.g. creating a date and verifying that the time is correct)?
  2. Is it IE-exclusive or does it happen on Edge as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Not really, it depends on the locale the user is in and when / if they have DST
  2. IE only

I also intentionally left this public so it can be overridden by users as an easy fix while I investigate any future bugs related to this

crisbeto
crisbeto approved these changes Oct 17, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 17, 2017
@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Oct 17, 2017
@mmalerba
Copy link
Contributor Author

need to fix test failures

@mmalerba
Copy link
Contributor Author

tests are good now

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 17, 2017
@julianobrasil julianobrasil mentioned this pull request Nov 2, 2017
Closed
@mmalerba mmalerba added the P2 The issue is important to a large percentage of users, with a workaround label Nov 2, 2017
@mmalerba mmalerba mentioned this pull request Nov 7, 2017
Closed
@josephperrott josephperrott merged commit 2f2325a into angular:master Nov 7, 2017
@mmalerba mmalerba deleted the dp-ie branch July 31, 2018 21:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IE 11 Datepicker not working Day incorrect in datepicker
4 participants
@mmalerba @crisbeto @googlebot @josephperrott