fix(select): wrong cursor on disabled select #7696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
reviewed
Oct 10, 2017
| @@ -56,7 +56,7 @@ | |||
| .mat-form-field-underline { | |||
| background-color: $underline-color; | |||
|
|
|||
| &.mat-disabled { | |||
| .mat-form-field-disabled & { | |||
There was a problem hiding this comment.
I think we have a rule that & can only go at the beginning in theme files, so that people can do stuff like this
.dark-theme {
@include angular-material-theme($dark-theme);
}
crisbeto
force-pushed
the
7695/select-wrong-cursor
branch
from
3e8dee1
to
d840150
Compare
|
Forgot that that lint rule was a thing @mmalerba, can you take another look? |
* Fixes some area of a disabled select having a `cursor: pointer`. * Replaces the `mat-disabled` class on the form field underline with a `mat-form-field-disabled` class on the form field itself to allow for easier styling. Fixes angular#7695.
crisbeto
force-pushed
the
7695/select-wrong-cursor
branch
from
d840150
to
97de632
Compare
mmalerba
approved these changes
Oct 11, 2017
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cursor: pointer.mat-disabledclass on the form field underline with amat-form-field-disabledclass on the form field itself to allow for easier styling.Fixes #7695.