Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress-spinner): spinner with narrower stroke not taking up entire element #7686

Merged
merged 1 commit into from
Oct 10, 2017

Conversation

crisbeto
Copy link
Member

Fixes spinners that have a stroke smaller than the default not taking up the entire available space.

Fixes #7674.

…ire element

Fixes spinners that have a stroke smaller than the default not taking up the entire available space.

Fixes angular#7674.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 10, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 10, 2017
@andrewseguin andrewseguin merged commit 2361983 into angular:master Oct 10, 2017
crisbeto added a commit to crisbeto/material2 that referenced this pull request Oct 11, 2017
Fixes the spinner stroke not being accurate on really small spinners (<20px). This is follow-up from angular#7686.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Oct 11, 2017
Fixes the spinner stroke not being accurate on really small spinners (<20px). This is follow-up from angular#7686.
andrewseguin pushed a commit that referenced this pull request Oct 12, 2017
…rs (#7725)

Fixes the spinner stroke not being accurate on really small spinners (<20px). This is follow-up from #7686.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circles in small spinners don't fill up SVG space
5 participants