-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(progress-spinner): fallback animation not working #7599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fixes the fallback animation not looking like it's working, because it displays a full circle. * Fixes an issue that causes the spinner to overflow its parent on IE and Edge. It's because they don't consider the `transform` when determining whether an element overflows. Fixes angular#7599.
fe4ad33
to
8758af1
Compare
When will this fix be available? |
After 5.1.0 update there's still a problem with the spinner. Hope it will be fixed soon. |
The spinner is static in Google Chrome Version 70.0.3538.102. Is this a bug ? |
@rohanshenoy96 it works for me locally. Can you post an example of it breaking? Note that using the |
This issue was I had imported NoopAnimationsModule due to which the animations were disabled. Thanks a lot @crisbeto |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
transform
when determining whether an element overflows.Fixes #7599.