Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress-spinner): fallback animation not working #7599

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 6, 2017

  • Fixes the fallback animation not looking like it's working, because it displays a full circle.
  • Fixes an issue that causes the spinner to overflow its parent on IE and Edge. It's because they don't consider the transform when determining whether an element overflows.

Fixes #7599.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround pr: needs review labels Oct 6, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 6, 2017
@crisbeto crisbeto mentioned this pull request Oct 6, 2017
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Fixes the fallback animation not looking like it's working, because it displays a full circle.
* Fixes an issue that causes the spinner to overflow its parent on IE and Edge. It's because they don't consider the `transform` when determining whether an element overflows.

Fixes angular#7599.
@walhow
Copy link

walhow commented Oct 27, 2017

When will this fix be available?

@plvice
Copy link

plvice commented Jan 25, 2018

After 5.1.0 update there's still a problem with the spinner. Hope it will be fixed soon.

@jesuscuesta
Copy link

You could use temporaly solution with CSS. This solution modify only style in IE 10+.
Reduce size of spinner.

/* Internet Explorer 10+, Microsoft Edge Browser */

_:-ms-lang(x), mat-progress-spinner circle {
  stroke-dasharray: 140px; 
}

Example with IE:
tempspinner

@rohanshenoy96
Copy link

rohanshenoy96 commented Nov 19, 2018

The spinner is static in Google Chrome Version 70.0.3538.102. Is this a bug ?
<mat-spinner [color]="'accent'" [mode]="'indeterminate'"> </mat-spinner>

@crisbeto
Copy link
Member Author

@rohanshenoy96 it works for me locally. Can you post an example of it breaking? Note that using the NoopAnimationsModule will remove the animation.

@rohanshenoy96
Copy link

This issue was I had imported NoopAnimationsModule due to which the animations were disabled. Thanks a lot @crisbeto

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants