Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material green contrast color does not match material.io guidelines contrast color #7490

Closed
codemasterover9000 opened this issue Oct 3, 2017 · 1 comment · Fixed by #7492
Assignees

Comments

@codemasterover9000
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

That colors exactly match the color palettes on material.io guidelines.

What is the current behavior?

Sass palette $mat-green's 500 hue, has a white contrast color instead of the guideline's black color

What are the steps to reproduce?

$green : mat-palette($mat-green);
$contrast: mat-contrast($mat-green, 500); //which is default

What is the use-case or motivation for changing an existing behavior?

It doesn't match the guidelines on material.io

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

angular/material 2.0.0-beta.10

Is there anything else we should know?

@devversion devversion self-assigned this Oct 3, 2017
devversion added a commit to devversion/material2 that referenced this issue Oct 3, 2017
As per the Material Design specifications, the 500-hue for the green palette should have a black (87% opacity) contrast color.

Fixes angular#7490
@kara kara closed this as completed in #7492 Oct 3, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants