-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ripple Effect in Button in Dialog has wrong position #7436
Comments
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Sep 30, 2017
Uses the `clientX` and `clientY` coordinates when creating a ripple, instead of taking `pageX`/`pageY` and subtracting the scroll position since the result is exactly the same. Using the client coordinates has the advantage of being simpler and not having to read the scroll position. Fixes angular#7436.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Sep 30, 2017
Uses the `clientX` and `clientY` coordinates when creating a ripple, instead of taking `pageX`/`pageY` and subtracting the scroll position since the result is exactly the same. Using the client coordinates has the advantage of being simpler and not having to read the scroll position. Fixes angular#7436.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Sep 30, 2017
Uses the `clientX` and `clientY` coordinates when creating a ripple, instead of taking `pageX`/`pageY` and subtracting the scroll position since the result is exactly the same. Using the client coordinates has the advantage of being simpler and not having to read the scroll position. Fixes angular#7436.
kara
pushed a commit
that referenced
this issue
Oct 3, 2017
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug, feature request, or proposal:
Bug
What is the expected behavior?
The ripple should originate from the mouse cursor.
What is the current behavior?
The ripple effect sometimes does not originate from the mouse cursor, but instead, somewhere above the mouse cursor.
What are the steps to reproduce?
Replicated here: https://embed.plnkr.co/HzjBCx/
What is the use-case or motivation for changing an existing behavior?
Ripple effect should probably work in this scenario
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Not sure which versions of everything are effected. The plunkr posted above is using TypeScript 2.1.1 but I'm not sure which version of Material its using.
The text was updated successfully, but these errors were encountered: