Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple Effect in Button in Dialog has wrong position #7436

Closed
willwsharp opened this issue Sep 30, 2017 · 1 comment · Fixed by #7446
Closed

Ripple Effect in Button in Dialog has wrong position #7436

willwsharp opened this issue Sep 30, 2017 · 1 comment · Fixed by #7446
Assignees

Comments

@willwsharp
Copy link

willwsharp commented Sep 30, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

The ripple should originate from the mouse cursor.

What is the current behavior?

The ripple effect sometimes does not originate from the mouse cursor, but instead, somewhere above the mouse cursor.

What are the steps to reproduce?

Replicated here: https://embed.plnkr.co/HzjBCx/

  1. Scroll to the bottom of the output
  2. Click on either "pick one" button
  3. Click on the "example" button to observe the incorrect ripple effect; it originates from above the button.
  4. Scroll back up to the top of the page and do the same thing; the ripple effect is working.

What is the use-case or motivation for changing an existing behavior?

Ripple effect should probably work in this scenario

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Not sure which versions of everything are effected. The plunkr posted above is using TypeScript 2.1.1 but I'm not sure which version of Material its using.

@crisbeto crisbeto self-assigned this Sep 30, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 30, 2017
Uses the `clientX` and `clientY` coordinates when creating a ripple, instead of taking `pageX`/`pageY` and subtracting the scroll position since the result is exactly the same. Using the client coordinates has the advantage of being simpler and not having to read the scroll position.

Fixes angular#7436.
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 30, 2017
Uses the `clientX` and `clientY` coordinates when creating a ripple, instead of taking `pageX`/`pageY` and subtracting the scroll position since the result is exactly the same. Using the client coordinates has the advantage of being simpler and not having to read the scroll position.

Fixes angular#7436.
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 30, 2017
Uses the `clientX` and `clientY` coordinates when creating a ripple, instead of taking `pageX`/`pageY` and subtracting the scroll position since the result is exactly the same. Using the client coordinates has the advantage of being simpler and not having to read the scroll position.

Fixes angular#7436.
@kara kara closed this as completed in #7446 Oct 3, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants