Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): prevent nbsp from getting butchered in AOT #7363

Merged
merged 1 commit into from
Sep 29, 2017
Merged

fix(select): prevent nbsp from getting butchered in AOT #7363

merged 1 commit into from
Sep 29, 2017

Conversation

mmalerba
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 27, 2017
crisbeto
crisbeto approved these changes Sep 27, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
Copy link
Member

Why did we need this in the first place? I don't really remember. I know that we had to do something similar for the input.

@mmalerba
Copy link
Contributor Author

In this case I needed to create a   but due to a bug in the whitespace stripping it was getting removed, so I did it as a string binding instead. But it seems like AOT translates '\xa0' to just 'xa0', fortunately it correctly translates '\u00A0'.

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 27, 2017
@jelbourn
Copy link
Member

Angular 4.4.4 is supposed to be out tomorrow (barring unforeseen complications) with a fix that will just make   work

@andrewseguin andrewseguin merged commit 2e71cac into angular:master Sep 29, 2017
@mmalerba mmalerba deleted the select-nbsp branch April 3, 2018 15:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmalerba @crisbeto @jelbourn @googlebot @andrewseguin