fix(chips): fix chip list focus and keyboard behaviors #7319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
approved these changes
Sep 26, 2017
src/lib/chips/chip-list.ts
Outdated
| @@ -432,9 +432,9 @@ export class MdChipList implements MdFormFieldControl<any>, ControlValueAccessor | |||
|
|
|||
| let isPrevKey = (code === (isRtl ? RIGHT_ARROW : LEFT_ARROW)); | |||
| let isNextKey = (code === (isRtl ? LEFT_ARROW : RIGHT_ARROW)); | |||
| let isBackKey = (code === BACKSPACE || code == DELETE || code == UP_ARROW || isPrevKey); | |||
| let isDeleteKey = code === BACKSPACE || code == DELETE; | |||
| // If they are on an empty input and hit backspace/delete/left arrow, focus the last chip | |||
There was a problem hiding this comment.
nit: not left arrow anymore
There was a problem hiding this comment.
Updated comment. Thanks for review!
tinayuangao
force-pushed
the
chips-7240
branch
from
7aa87ec
to
2baf3f4
Compare
jelbourn
reviewed
Sep 26, 2017
src/lib/chips/chip-list.ts
Outdated
| // If they are on an empty input and hit backspace/delete/left arrow, focus the last chip | ||
| if (isInputEmpty && isBackKey) { | ||
| let isDeleteKey = code === BACKSPACE || code == DELETE; | ||
| // If they are on an empty input and hit backspace/delete, focus the last chip |
There was a problem hiding this comment.
I'm not sure the delete key should do this in addition to backspace. In both Drive and GMail, the delete key just does nothing when your focus is on the empty input.
There was a problem hiding this comment.
Removed delete key. Thanks for review!
tinayuangao
force-pushed
the
chips-7240
branch
from
2baf3f4
to
6d542ff
Compare
tinayuangao
force-pushed
the
chips-7240
branch
from
6d542ff
to
b385300
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7240 #7242