Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): losing focus when selecting values through binding #7296

Merged
merged 1 commit into from
Sep 29, 2017
Merged

fix(select): losing focus when selecting values through binding #7296

merged 1 commit into from
Sep 29, 2017

Conversation

crisbeto
Copy link
Member

Fixes an issue that caused focus to be lost after selecting a value on a select that doesn't use Angular forms.

Fixes #7092.

@crisbeto
fix(select): losing focus when selecting values through binding
8b17744 
Fixes an issue that caused focus to be lost after selecting a value on a select that doesn't use Angular forms.

Fixes angular#7092.
@crisbeto crisbeto added the in progress This issue is currently in progress label Sep 25, 2017
@crisbeto crisbeto self-assigned this Sep 25, 2017
@crisbeto crisbeto requested a review from kara as a code owner September 25, 2017 16:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 25, 2017
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) pr: needs review and removed in progress This issue is currently in progress labels Sep 25, 2017
@crisbeto crisbeto assigned kara and unassigned crisbeto Sep 25, 2017
kara
kara approved these changes Sep 25, 2017
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 25, 2017
@kara kara removed their assignment Sep 25, 2017
@andrewseguin andrewseguin merged commit 86bea91 into angular:master Sep 29, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

select: focus does not return to trigger after selecting item
4 participants
@crisbeto @kara @googlebot @andrewseguin