Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autocomplete): add md-autocomplete classes to overlay panel #7176

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

crisbeto
Copy link
Member

Transfers any classes added to md-autocomplete to the resulting panel, allowing for easier styling similarly to md-menu.

Fixes #4196.

@crisbeto crisbeto requested a review from kara as a code owner September 19, 2017 17:54
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 19, 2017
@willshowell
Copy link
Contributor

Related #6618. And would it be possible to support NgClass syntax?

@crisbeto
Copy link
Member Author

I would rather keep it simple and in line with md-menu. It can be added later if people ask for it.

@willshowell
Copy link
Contributor

Ok cool! Also does it support removal of classes? It looks like you can only add classes, though I haven't tested.

@crisbeto
Copy link
Member Author

It doesn't, but the intention here is just to allow styles to be overridden. My worry with making it more dynamic is that people may end up putting it in a state where it interferes with the panel being toggled correctly.

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed their assignment Sep 19, 2017
@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 19, 2017
Transfers any classes added to `md-autocomplete` to the resulting panel, allowing for easier styling similarly to `md-menu`.

Fixes angular#4196.
@andrewseguin
Copy link
Contributor

Merging this in but it includes an md- in the comment, can you send another PR that removes md-autocomplete and changes it to autocomplete or mat-autocomplete?

@andrewseguin andrewseguin merged commit f8cd790 into angular:master Sep 29, 2017
crisbeto added a commit to crisbeto/material2 that referenced this pull request Sep 30, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request for autocomplete - more control over panel width
5 participants