-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autocomplete): add md-autocomplete classes to overlay panel #7176
Conversation
Related #6618. And would it be possible to support NgClass syntax? |
I would rather keep it simple and in line with |
Ok cool! Also does it support removal of classes? It looks like you can only add classes, though I haven't tested. |
It doesn't, but the intention here is just to allow styles to be overridden. My worry with making it more dynamic is that people may end up putting it in a state where it interferes with the panel being toggled correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Transfers any classes added to `md-autocomplete` to the resulting panel, allowing for easier styling similarly to `md-menu`. Fixes angular#4196.
12994d6
to
35f37d2
Compare
Merging this in but it includes an |
This is follow-up from angular#7176.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Transfers any classes added to
md-autocomplete
to the resulting panel, allowing for easier styling similarly tomd-menu
.Fixes #4196.