fix(radio): defaulting to invalid name attribute #7131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
approved these changes
Sep 17, 2017
src/lib/radio/radio.spec.ts
Outdated
| @@ -7,7 +7,7 @@ import {dispatchFakeEvent, FakeViewportRuler} from '@angular/cdk/testing'; | |||
| import {RIPPLE_FADE_IN_DURATION, RIPPLE_FADE_OUT_DURATION} from '@angular/material/core'; | |||
| import {MdRadioButton, MdRadioChange, MdRadioGroup, MdRadioModule} from './index'; | |||
|
|
|||
| describe('MdRadio', () => { | |||
| fdescribe('MdRadio', () => { | |||
There was a problem hiding this comment.
The fdescribe has been added accidentally here.
crisbeto
force-pushed
the
radio-invalid-name
branch
from
8f09ca3
to
4db4da9
Compare
devversion
added
pr: lgtm
action: merge
Fixes the radio button defaulting to `name="undefined"` for the underlying input, if the consumer hasn't passed in a name. Relates to angular#7130.
crisbeto
force-pushed
the
radio-invalid-name
branch
from
4db4da9
to
734d808
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the radio button defaulting to
name="undefined"for the underlying input, if the consumer hasn't passed in a name.Relates to #7130.