perf: memory leak when subscribing to zone events #6918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn,
josephperrott,
kara and
mmalerba
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
6905/zone-leaks
branch
from
d3bec5b
to
2b82901
Compare
jelbourn
added
pr: lgtm
action: merge
Fixes a few memory leaks that were caused by subscribing to `NgZone.onMicrotaskEmpty` or `NgZone.onStable`. Because the two streams are `EventEmitters`, the subscription doesn't get GC-ed correctly. These changes switch to converting the emitters to observables before subscribing to them. Fixes angular#6905.
crisbeto
force-pushed
the
6905/zone-leaks
branch
from
2b82901
to
66dafa5
Compare
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Sep 15, 2017
Fixes a few memory leaks that were caused by subscribing to `NgZone.onMicrotaskEmpty` or `NgZone.onStable`. Because the two streams are `EventEmitters`, the subscription doesn't get GC-ed correctly. These changes switch to converting the emitters to observables before subscribing to them. Fixes angular#6905.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few memory leaks that were caused by subscribing to
NgZone.onMicrotaskEmptyorNgZone.onStable. Because the two streams areEventEmitters, the subscription doesn't get GC-ed correctly. These changes switch to converting the emitters to observables before subscribing to them.Fixes #6905.