feat(dialog): add afterOpen to MdDialogRef #6887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a hook for initializing component after animation is complete.
googlebot
added
the
cla: yes
jelbourn
reviewed
Sep 6, 2017
src/lib/dialog/dialog-ref.ts
Outdated
| RxChain.from(_containerInstance._animationStateChanged) | ||
| .call(filter, event => event.phaseName === 'done' && event.toState === 'enter') | ||
| .call(first) | ||
| .subscribe(() => this._afterOpen.next()); |
crisbeto
reviewed
Sep 6, 2017
| /** Subject for notifying the user that the dialog has finished closing. */ | ||
| private _afterClosed: Subject<any> = new Subject(); | ||
| private _afterClosed = new Subject<any>(); |
There was a problem hiding this comment.
These subjects should be Subject<void>.
There was a problem hiding this comment.
Don't they carry the close value of the dialog?
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Sep 15, 2017
* feat(dialog): add afterOpen to MdDialogRef Provides a hook for initializing component after animation is complete. * Complete afterOpen observable
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a hook for initializing component after animation is
complete.
Relates to #3616 (comment).