-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sort): reverse directions and better animation #6802
fix(sort): reverse directions and better animation #6802
Conversation
src/lib/sort/sort-header.ts
Outdated
@@ -52,8 +52,8 @@ import {getMdSortHeaderNotContainedWithinMdSortError} from './sort-errors'; | |||
changeDetection: ChangeDetectionStrategy.OnPush, | |||
animations: [ | |||
trigger('indicatorRotate', [ | |||
state('asc', style({transform: 'rotate(45deg)'})), | |||
state('desc', style({transform: 'rotate(225deg)'})), | |||
state('asc', style({transform: 'rotate(225deg)', top: '2px'})), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's with the 2px
? Needs a comment at least
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I haven't been able to reproduce it with a simple test case (and can't upload my regular site), but with this patch in place (beta 11), I'm seeing the sort header "stem" and indicator appearing horizontally next to one another rather than vertically. I was able to fix this by (with the debugger) adding a "flex-direction: column" style to the "mat-sort-header-arrow" class. Would it be possible to do so in the official release? |
@mcalmus Please open an issue for bug reports. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #6198