fix(slide-toggle): support native tabindex attribute #6613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the slide-toggle only allows changing the tabIndex using the `tabIndex` binding. Using the native `tabindex` attribute doesn't have any affect. With this change the native tabindex property will be respected. References angular#6465
googlebot
added
the
cla: yes
jelbourn
reviewed
Aug 23, 2017
| import {CanDisable} from './disabled'; | ||
|
|
||
| /** @docs-private */ | ||
| export interface CanTabIndex { |
There was a problem hiding this comment.
Addressed the feedback discussed per Chat.
jelbourn
reviewed
Aug 23, 2017
|
|
||
| get tabIndex(): number { return this.disabled ? -1 : this._tabIndex || defaultTabIndex; } | ||
| set tabIndex(value: number) { | ||
| if (typeof value !== 'undefined') { |
There was a problem hiding this comment.
Yeah, that doesn't really have any affect with the fallback. I've updated the getter/setter to handle the fall back better (also with a comment)
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the slide-toggle only allows changing the tabIndex using the
tabIndexbinding. Using the nativetabindexattribute doesn't have any affect. With this change the native tabindex property will be respected.Note: The
tabIndexmixin is more like a proposal to ensure that the tabIndex property will be handled consistent across Material components.References #6465