Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last build changes in .mat-figure style #6586

Closed
ghost opened this issue Aug 22, 2017 · 6 comments · Fixed by #6578
Closed

Last build changes in .mat-figure style #6586

ghost opened this issue Aug 22, 2017 · 6 comments · Fixed by #6578
Assignees

Comments

@ghost
Copy link

ghost commented Aug 22, 2017

Hello team,

Bug, feature request, or proposal:

Question

What is the expected behavior?

In the last release (2.0.0-beta.8), in the .mat-figure style configuration we have

top: 0;
right: 0;
bottom: 0;
left: 0;

What is the current behavior?

In the last build I test, style configuration (only for top, right, bottom and left) is missing. Is this normal?

What are the steps to reproduce?

Use last available build.

What is the use-case or motivation for changing an existing behavior?

I'm a little bit worry if in the next release a lot of people will be surprised by this change.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Last build

Is there anything else we should know?

I hope my message is not spam, but I need some new functionalities of the latest build but it changes some design features of my website and I would like to know why those changes have been done.

Thanks.

@willshowell
Copy link
Contributor

For reference,

beta.8: https://plnkr.co/edit/xLFDhss37qVGg0agTFtK?p=preview
master: https://plnkr.co/edit/bgkNSnKEUIpIxfWkauzA?p=preview

@crisbeto the change was made in #6486. Was the uncentering of content intentional?

@crisbeto
Copy link
Member

The changes from #6486 are equivalent to the old styling. If you take a look at the mat-fill mixin, it adds the exact same styles. As for the uncentering, I'm not quite sure what introduced it, but it should be fixed by #6578.

@willshowell
Copy link
Contributor

I think here you can see that the top/bottom/right/left styles were removed from .mat-figure and added to the parent .mat-grid-tile instead. In any case, #6578 looks like a fine solution.

@willshowell
Copy link
Contributor

willshowell commented Aug 22, 2017

Further I think adding mat-fill to .mat-grid-tile doesn't make sense since the tile is repositioned with inline styles. The mat-fill styles get overridden any way.

@crisbeto
Copy link
Member

Oh, that feels more like a typo. I'll update #6578.

@crisbeto crisbeto self-assigned this Aug 22, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 22, 2017
Fixes the grid list tile not expanding completely.

Fixes angular#6586.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants