Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk): move cdkScrollable, ScrollDispatcher, and ViewportRuler out of overlay #6547

Merged
merged 1 commit into from
Aug 23, 2017
Merged

feat(cdk): move cdkScrollable, ScrollDispatcher, and ViewportRuler out of overlay #6547

merged 1 commit into from
Aug 23, 2017

Conversation

jelbourn
Copy link
Member

No description provided.

@jelbourn jelbourn requested review from kara and crisbeto August 18, 2017 21:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 18, 2017
crisbeto
crisbeto approved these changes Aug 18, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 21, 2017
@kara kara added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Aug 22, 2017
@kara
Copy link
Contributor

kara commented Aug 22, 2017

@jelbourn Can you rebase when you get a chance?

@jelbourn
Copy link
Member Author

Rebased

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Aug 22, 2017
@kara kara merged commit 0f6a2ec into angular:master Aug 23, 2017
@jelbourn jelbourn deleted the cdk-scrolling branch April 2, 2018 22:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@kara kara Awaiting requested review from kara

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jelbourn @kara @crisbeto @googlebot