Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdDialog will stack on top of each other if enter key is continually pressed #6513

Closed
kylecannon opened this issue Aug 16, 2017 · 2 comments · Fixed by #6524
Closed

MdDialog will stack on top of each other if enter key is continually pressed #6513

kylecannon opened this issue Aug 16, 2017 · 2 comments · Fixed by #6524
Assignees

Comments

@kylecannon
Copy link

Bug, feature request, or proposal:

Dialogs will stack on top of each other if you press enter repeatedly

What is the expected behavior?

focus should be lost on the button opening the dialog after the dialog is opened.

What is the current behavior?

Dialogs continue to stack

What are the steps to reproduce?

  1. Go to Material's Dialog Page
  2. Press "Open dialog"
  3. After dialog is open, continue hitting enter to eventually see the overlay of the dialog to turn to black

What is the use-case or motivation for changing an existing behavior?

Focus shouldn't be on the button that was clicked to open anymore.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Tested to happen on chrome 59 on material.angular.io site.

Is there anything else we should know?

If this is expected behavior, there should be a configurable option to disable this.

@crisbeto crisbeto self-assigned this Aug 17, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 17, 2017
…ound

Moves focus onto the `md-dialog-container`, if it doesn't contain any focusable elements. The reasoning behind this change is that not moving focus at all will leave the user behind on the dialog trigger, allowing them to be able to tab behind the dialog.

Fixes angular#6513.
@kylecannon
Copy link
Author

Thank you for the quick turn around @crisbeto and @kara

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants