fix(chips): set appropriate aria-orientation #6464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
tinayuangao
reviewed
Aug 16, 2017
src/lib/chips/chip-list.ts
Outdated
| @@ -45,6 +45,7 @@ import {coerceBooleanProperty} from '@angular/cdk/coercion'; | |||
| host: { | |||
| '[attr.tabindex]': '_tabIndex', | |||
| 'role': 'listbox', | |||
| 'aria-orientation': 'horizontal', | |||
There was a problem hiding this comment.
Stacked chips are vertical.
I'm okay with the change. But I think we need to update the docs to let developers set correct aria-orientation if they use stacked chip list.
crisbeto
force-pushed
the
chips-orientation
branch
from
5c0be39
to
0850a7f
Compare
|
Addressed the feedback. Can you take another look @tinayuangao? |
tinayuangao
reviewed
Aug 16, 2017
src/lib/chips/chips.md
Outdated
| @@ -33,8 +33,19 @@ chips are neither selectable nor focusable. Currently, disabled chips receive no | |||
| Users can move through the chips using the arrow keys and select/deselect them with the space. Chips | |||
| also gain focus when clicked, ensuring keyboard navigation starts at the appropriate chip. | |||
|
|
|||
| ### Orientation | |||
| If you want the chips in the list to be stacked verticall, instead of horizontally, you can apply | |||
Based on the [accessibility guidelines](https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox), the `listbox` role has a default `aria-orientation` of `vertical`, however the chips in a chip list are horizontal.
crisbeto
force-pushed
the
chips-orientation
branch
from
0850a7f
to
88976d8
Compare
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Sep 15, 2017
Based on the [accessibility guidelines](https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox), the `listbox` role has a default `aria-orientation` of `vertical`, however the chips in a chip list are horizontal.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the accessibility guidelines, the
listboxrole has a defaultaria-orientationofvertical, however the chips in a chip list are horizontal.