Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escaping out of menu/autocomplete within a dialog causes the dialog to close #6223

Closed
willshowell opened this issue Aug 2, 2017 · 1 comment · Fixed by #6226
Closed

Escaping out of menu/autocomplete within a dialog causes the dialog to close #6223

willshowell opened this issue Aug 2, 2017 · 1 comment · Fixed by #6226
Assignees
@crisbeto

Comments

@willshowell
Copy link
Contributor

Bug, feature request, or proposal:

Bug

Expected

Closing an autocomplete or menu from within a dialog via esc should only close the autocomplete panel / menu panel.

Current

Pressing esc closes the top dialog.

Reproduction

http://plnkr.co/edit/o9EQlYQKstYQdNsanheF?p=preview
@willshowell willshowell mentioned this issue Aug 2, 2017
Closed
@crisbeto crisbeto self-assigned this Aug 2, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 2, 2017
@crisbeto
fix(autocomplete,datepicker,menu): closing parent dialog by pressing …
6ae7507 
…escape

Prevents the autocomplete, datepicker and menu components from closing their parent dialog when the user presses escape.

Fixes angular#6223.
@crisbeto crisbeto mentioned this issue Aug 2, 2017
Merged
@crisbeto crisbeto added the has pr label Aug 2, 2017
tinayuangao pushed a commit that referenced this issue Aug 2, 2017
@crisbeto @tinayuangao
fix(autocomplete,datepicker,menu): closing parent dialog by pressing …
916d1f3 
…escape (#6226)

Prevents the autocomplete, datepicker and menu components from closing their parent dialog when the user presses escape.

Fixes #6223.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(autocomplete,datepicker,menu): closing parent dialog by pressing escape crisbeto/material2
2 participants
@crisbeto @willshowell