Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subheader line-height is too high #6214

Closed
grizzm0 opened this issue Aug 2, 2017 · 1 comment · Fixed by #6221
Closed

Subheader line-height is too high #6214

grizzm0 opened this issue Aug 2, 2017 · 1 comment · Fixed by #6221
Assignees
@devversion

Comments

@grizzm0
Copy link
Contributor

grizzm0 commented Aug 2, 2017 •
edited
Loading

Bug, feature request, or proposal:

Proposal

What is the expected behavior?

screenshot 2017-08-02 10 15 57

What is the current behavior?

screenshot 2017-08-02 10 14 44

What are the steps to reproduce?

What is the use-case or motivation for changing an existing behavior?

The current line-height is 24px + 16*2px padding = 56px while the height of the element is only 48px. Resulting in the text being pushed down a bit. The line height should be 16px.

I also noticed that the subheader size is changed in dense mode while the spec does not say anything about this. I suggest keeping the size the same for dense lists as this only gives us 8px of height to fit a 12px font into.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Is there anything else we should know?
@devversion devversion self-assigned this Aug 2, 2017
devversion added a commit to devversion/material2 that referenced this issue Aug 2, 2017
@devversion
fix(list): properly align contents in subheader
110c54c 
* The line-height of the subheaders is currently based on the typography level. This is problematic because the subheader is set to a specific height and can't grow/shrink accordingly.

Fixes angular#6214
@devversion devversion mentioned this issue Aug 2, 2017
Merged
tinayuangao pushed a commit that referenced this issue Aug 2, 2017
@devversion @tinayuangao
fix(list): properly align contents in subheader
5a6071e 
* The line-height of the subheaders is currently based on the typography level. This is problematic because the subheader is set to a specific height and can't grow/shrink accordingly.

Fixes #6214
tinayuangao pushed a commit that referenced this issue Aug 2, 2017
@devversion @tinayuangao
fix(list): properly align contents in subheader
8717a38 
* The line-height of the subheaders is currently based on the typography level. This is problematic because the subheader is set to a specific height and can't grow/shrink accordingly.

Fixes #6214
tinayuangao pushed a commit that referenced this issue Aug 2, 2017
@devversion @tinayuangao
fix(list): properly align contents in subheader (#6221)
4e6e42e 
* fix(list): properly align contents in subheader

* The line-height of the subheaders is currently based on the typography level. This is problematic because the subheader is set to a specific height and can't grow/shrink accordingly.

Fixes #6214

* Address feedback
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(list): properly align contents in subheader devversion/material2
2 participants
@grizzm0 @devversion