fix(select): set aria-multiselectable for multi-select #6110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
approved these changes
Aug 2, 2017
| multiFixture.detectChanges(); | ||
| select = multiFixture.debugElement.query(By.css('md-select')).nativeElement; | ||
|
|
||
| expect(select.getAttribute('aria-multiselectable')).toBe('true'); |
There was a problem hiding this comment.
Can you add a test to check that this attribute is not added to normal selects?
There was a problem hiding this comment.
Not added at all or set to false? AFAIK it is allowed to be false.
Sets the `aria-multiselectable` attribute to multi-select instances, as per https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox.
crisbeto
force-pushed
the
select-multiselectable
branch
from
72c654e
to
e453d19
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the
aria-multiselectableattribute to multi-select instances, as per https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox.