feat(select): allow disabling ripples for options #5967
Conversation
devversion
commented
Jul 22, 2017
devversion
commented
- Adds a binding that allows developers to disable ripples for every option in a select.
googlebot
added
the
cla: yes
src/lib/core/option/option.ts
Outdated
| @@ -99,17 +92,22 @@ export class MdOption extends _MdOptionMixinBase implements CanDisableRipple { | |||
| get disabled() { return (this.group && this.group.disabled) || this._disabled; } | |||
| set disabled(value: any) { this._disabled = coerceBooleanProperty(value); } | |||
|
|
|||
| /** Whether ripples for the option are disabled. */ | |||
| @Input() | |||
There was a problem hiding this comment.
I don't think that this should be an Input. The only way to disable ripples on options should be programmatic. It also means that we won't have to coerce the value.
There was a problem hiding this comment.
The ability to disable the ripples from a binding has been already added in addf1ce. I don't really see anything that would go against just providing this flexibility.
There was a problem hiding this comment.
I think that there might be some overhead to having to maintain the input. Also there's the extra JS being generated because of the getter and setter, although we can't really avoid those because it has to markForCheck.
There was a problem hiding this comment.
It might be true that it might not happen that someone just disables ripples for a single option.
From the payload size perspective it shouldn't make any difference, so it's more a question of API design.
I'm fine removing the @Input here. Also since addf1ce is not in master that long, I assume it won't be a breaking change.
There was a problem hiding this comment.
Updated the tests. Please have another look.
src/lib/select/select.spec.ts
Outdated
| expect(overlayContainerElement.querySelectorAll('.mat-ripple-element').length) | ||
| .toBe(0, 'Expected no ripples to show up initially.'); | ||
|
|
||
| dispatchFakeEvent(options[0], 'mousedown'); |
There was a problem hiding this comment.
I'm not sure whether we care about the DOM events that are happening in these tests since this is tested well enough in the ripple tests. Looping through all the options and verifying that the flag is correct should be enough. Also it could use a test where it adds a new option and checks that it got the proper disableRipple value.
There was a problem hiding this comment.
Not sure about that. This test would just ensure that the disableRipple property changed properly and also got reflected properly in the view. Verifying for example that markForCheck is placed properly.
I agree on adding a test for the property itself though.
There was a problem hiding this comment.
My issue with this approach is that it's testing functionality that it's not responsible for. That functionality already has tests of its own.
There was a problem hiding this comment.
That's an argument. I will change it.
devversion
force-pushed
the
feat/select-disable-ripples
branch
from
c072d27
to
81ca542
Compare
| fixture.componentInstance.disableRipple = true; | ||
| fixture.detectChanges(); | ||
|
|
||
| expect(options.every(option => option.disableRipple === true)) |
There was a problem hiding this comment.
Can be reduced to option => option.disableRipple.
There was a problem hiding this comment.
True. But I want to make it clear that we are checking for a truthy value here.
crisbeto
added
pr: lgtm
action: merge
|
Rebase please |
* Adds a binding that allows developers to disable ripples for every option in a select.
devversion
force-pushed
the
feat/select-disable-ripples
branch
from
81ca542
to
b2c5c67
Compare
|
@andrewseguin Done. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
