Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): make sure 1-line hint is fully contained by input container. #5912

Merged
merged 1 commit into from
Jul 25, 2017
Merged

fix(input): make sure 1-line hint is fully contained by input container. #5912

merged 1 commit into from
Jul 25, 2017

Conversation

mmalerba
Copy link
Contributor

fixes #5539

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 20, 2017
@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 21, 2017
@code-tree
Copy link
Contributor

This doesn't appear to fix overflow in a dialog.

http://plnkr.co/edit/1duXQ6?p=preview (the button opens example dialog)

@mmalerba
Copy link
Contributor Author

@code-tree I don't see any scrollbar in that demo. The demo also doesn't contain this change yet

@code-tree
Copy link
Contributor

@mmalerba Yes, sorry, to clarify, I merged these changes locally and tested but the dialog still showed a scrollbar when input has an md-hint.

Strange you don't see it in the plunker though. I'm using Chrome Linux 60.0.3112.20

image

@andrewseguin andrewseguin merged commit ca3a3b8 into angular:master Jul 25, 2017
@mmalerba mmalerba deleted the input-size branch April 3, 2018 15:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

md-hint, md-error overflow the md-input-container
4 participants
@mmalerba @code-tree @andrewseguin @googlebot