fix(sidenav): first animation not working in Angular 4.2+ #5821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the first opening/closing animation not working in newer Angular versions. The issue is due to the fact that Angular no longer evaluates the `_enableTransitions` binding after we've set it in the microtask empty callback. These changes switch to setting the class directly, which also has the advantage of being a little more compact. Fixes angular#5673.
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
mmalerba
approved these changes
Jul 17, 2017
amitport
reviewed
Jul 20, 2017
| // Give the view a chance to render the initial state, then enable transitions. Note that we | ||
| // don't use data binding, because we're not guaranteed that newer version of Angular will | ||
| // re-evaluate them after we set the flag here. | ||
| first.call(this._ngZone.onMicrotaskEmpty).subscribe(() => { |
There was a problem hiding this comment.
Isn't this what AfterViewInit is for? just wondering. Wouldn't want to have to do this in my own components
There was a problem hiding this comment.
The main point of this is to defer the animation until the next change detection cycle, because we don't want sidenavs to animate in on load. Setting the flag in AfterViewInit is still a little too early. This should be easier in Angular 4.3 with the [@.disabled] bindings.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the first opening/closing animation not working in newer Angular versions. The issue is due to the fact that Angular no longer evaluates the
_enableTransitionsbinding after we've set it in the microtask empty callback. These changes switch to setting the class directly, which also has the advantage of being a little more compact.Fixes #5673.