fix(input): add overflow:hidden when calculating autosize height #5773

mmalerba · 2017-07-14T21:11:37Z

jelbourn · 2017-07-14T21:13:51Z

src/lib/input/autosize.ts

    textarea.style.height = 'auto';
+    textarea.style.overflow = 'hidden';


Is there a way to write a unit test for this?

could find some text that previously wasn't calculated right and check that its height is correct now I suppose

jelbourn

LGTM

angular-automatic-lock-bot · 2019-09-08T16:02:20Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

_{This action has been performed automatically by a bot.}

fix(input): add overflow:hidden when calculating autosize height

224bd9f

mmalerba assigned jelbourn Jul 14, 2017

mmalerba requested a review from jelbourn July 14, 2017 21:11

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 14, 2017

mmalerba added the pr: needs review label Jul 14, 2017

jelbourn reviewed Jul 14, 2017

View reviewed changes

add screenshot tests for autosize

3273409

mmalerba force-pushed the input-resize branch from e85d253 to 3273409 Compare July 14, 2017 22:23

jelbourn approved these changes Jul 14, 2017

View reviewed changes

jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 14, 2017

kara merged commit e0fc526 into angular:master Jul 20, 2017

mmalerba deleted the input-resize branch April 3, 2018 15:18

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019

Provide feedback

		textarea.style.height = 'auto';
		textarea.style.overflow = 'hidden';