fix(dialog): prevent dialog from opening while another dialog is animating #5769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating Prevents dialogs from being opened while other dialogs are animating. Fixes angular#5713.
googlebot
added
the
cla: yes
jelbourn
reviewed
Jul 17, 2017
| @@ -91,11 +91,19 @@ export class MdDialog { | |||
| */ | |||
| open<T>(componentOrTemplateRef: ComponentType<T> | TemplateRef<T>, | |||
| config?: MdDialogConfig): MdDialogRef<T> { | |||
|
|
|||
| const inProgressDialog = this._openDialogs.find(dialog => dialog._isAnimating()); | |||
There was a problem hiding this comment.
Do you think it's worthwhile to key this on the component as well? E.g., if I try to open(UserProfile) multiple times in a row, they get blocked, but if I try to open(UserProfile) and open(AdminSettings) at the same time then they both open?
There was a problem hiding this comment.
I see how that would be useful, but it's probably too much trouble. There's only a 400ms window after you open a dialog where this can happen.
There was a problem hiding this comment.
Let's go with this for now and see if we get any feedback.
jelbourn
added
pr: lgtm
action: merge
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 26, 2017
The behavior where we don't allow new dialogs to be opened while a dialog is animating was introduced initially in angular#5769 to avoid issues where the user might open multiple dialogs by accident if they press enter one too many times. This is problematic because it also means that the consumer is blocked from opening dialogs for certain 300ms intervals. These changes approach the issue differently by moving focus onto the dialog container immediately while it's animating. Fixes angular#5769.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 28, 2017
The behavior where we don't allow new dialogs to be opened while a dialog is animating was introduced initially in angular#5769 to avoid issues where the user might open multiple dialogs by accident if they press enter one too many times. This is problematic because it also means that the consumer is blocked from opening dialogs for certain 300ms intervals. These changes approach the issue differently by moving focus onto the dialog container immediately while it's animating. Fixes angular#6560.
andrewseguin
pushed a commit
that referenced
this pull request
Nov 2, 2017
…8051) The behavior where we don't allow new dialogs to be opened while a dialog is animating was introduced initially in #5769 to avoid issues where the user might open multiple dialogs by accident if they press enter one too many times. This is problematic because it also means that the consumer is blocked from opening dialogs for certain 300ms intervals. These changes approach the issue differently by moving focus onto the dialog container immediately while it's animating. Fixes #6560.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents dialogs from being opened while other dialogs are animating.
Fixes #5713.
Note: I wasn't able to write a test that properly captures the issue that this is solving (I tried using the
BrowserAnimationsModuleinstead of the noop module as well). In unit tests, it seems like the callbacks are fired immediately, whereas we have the animations disabled in the e2e tests in general.