fix(demo-app): resolve mapping paths in relative. #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently, the demo app is mapping its core and components absolutely (`/`), which is working perfectly for the served application * This commit changes the absolute mapping paths to relative paths. This allows developers, to serve the demo-app also in sub-directories. Also this is required for some bundlers, for example SystemJS Builder is not able to build a bundle of the demo app, with absolute paths, because the baseURL may be different. References angular#553
googlebot
added
the
cla: yes
|
LGTM. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/), which is working perfectly for the served applicationThis allows developers, to serve the demo-app in sub-directories (not only in the root).
Notice, that all other mappings in the configurations are also relative, so it will also restore consistency.
This is also required for some bundlers, for example SystemJS Builder is not able to build a bundle of the demo app, with absolute paths, because the baseURL may have changed.
This is a required commit, for the Live Preview (#533), because I'm planning to bundle the output, to accelerate deploy and load time.
References #553