fix(card): prevent content from overlapping footer #5583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Jul 11, 2017
src/lib/card/card.scss
Outdated
| min-height: 5px; | ||
| bottom: 0; | ||
| left: 0; | ||
| $margin: -$mat-card-default-padding; |
There was a problem hiding this comment.
Could you add comments that explain the negative margins? I find those to usually be hard to grok when coming back to the styles later.
* Prevents content from overlapping the `md-card-footer` component by making the footer `position: static`. * Uses content projection to ensure that the footer will always be at the bottom of a card. Fixes angular#5486.
crisbeto
force-pushed
the
5486/card-footer-positioning
branch
from
bdd9c14
to
46e5c23
Compare
|
Addressed the feedback @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md-card-footercomponent by making the footerposition: static.Fixes #5486.