Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button-toggle): button-toggle module depends on forms module #5542

Merged
merged 1 commit into from
Jul 9, 2017

Conversation

devversion
Copy link
Member

@devversion devversion commented Jul 6, 2017

  • Fixes that the button-toggle module depends on the forms module.
  • Tests with forms and without forms have been separated to ensure that button-toggle works without forms as expected.

Note: It's clear to me that there is the question whether we should do this or not, but I finished most of this yesterday so I'm still pushing the PR.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 6, 2017
@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 6, 2017
@mmalerba mmalerba merged commit 9ab0c90 into angular:master Jul 9, 2017
@devversion devversion deleted the fix/button-toggle-module branch November 11, 2017 10:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants