-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(card): unable to bind to align attribute #5495
Conversation
Fixes not being able to bind to the `align` attribute on the `md-card-actions`. Fixes angular#5490.
I'm in general interested in changing behaviors like this to use just css classes, but it's something we'd have to do for the whole library. Any thoughts? |
I prefer the CSS classes as well since these bindings just add unnecessary bloat. I can do it in the few other places that we have something similar, but it'll be a breaking change. |
Might be good to first compile a list of places where we could do this and see how major the change would be |
@jelbourn here's a list where changes would be necessary:
There's also the |
Let me see how widely they're used inside Google first |
About:
It would be pretty time consuming to update these, so updating the binding is how I would go for now. If we run out of more important stuff to do before end-of-beta then we can revisit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes not being able to bind to the
align
attribute on themd-card-actions
.Note: If we're okay with a breaking change, this may be simpler to do with a CSS class.
Fixes #5490.