Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move observe-content to cdk #5438

Merged
merged 1 commit into from
Jun 30, 2017
Merged

feat: move observe-content to cdk #5438

merged 1 commit into from
Jun 30, 2017

Conversation

devversion
Copy link
Member

  • Moves the observe content directive to the CDK package.

@devversion
feat: move observe-content to cdk
653bcda 
* Moves the observe content directive to the CDK package.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 30, 2017
jelbourn
jelbourn approved these changes Jun 30, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed pr: needs review labels Jun 30, 2017
@jelbourn
Copy link
Member

Caretaker note: will need a build rule

@tinayuangao tinayuangao merged commit b00f838 into angular:master Jun 30, 2017
amcdnl pushed a commit to amcdnl/material2 that referenced this pull request Jul 8, 2017
@devversion @amcdnl
feat: move observe-content to cdk (angular#5438)
b211611 
* Moves the observe content directive to the CDK package.
@devversion devversion deleted the feat/move-observe-content-cdk branch November 11, 2017 10:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @tinayuangao