fix(tooltip): remove native event listener on component destroy #5144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Please merge ASAP: it is causing huge mem-leaks in my application so it makes the Chrome tab to crash in few minutes... |
jelbourn
reviewed
Jun 19, 2017
src/lib/tooltip/tooltip.ts
Outdated
| () => this.show()); | ||
| this._leaveListener = _renderer.listen(_elementRef.nativeElement, | ||
| 'mouseleave', | ||
| () => this.hide()); |
There was a problem hiding this comment.
Prefer breaking at the higher syntactic level:
this._enterListener =
_renderer.listen(_elementRef.nativeElement, 'mouseenter', () => this.show());
this._leaveListener =
_renderer.listen(_elementRef.nativeElement, 'mouseleave', () => this.hide());
|
@jelbourn I've resolved the comment and rebased the commit |
|
@michastreppel please revert all of the formatting changes to the file |
|
@jelbourn Done |
jelbourn
added
pr: lgtm
action: merge
added 3 commits
June 27, 2017 08:49
Component should clean up events it has registered to. Closes #4499
|
@jelbourn @tinayuangao I've rebased this PR. |
|
@jelbourn Please merge this pr asap. The tooltips are causing major issues in my app. |
amcdnl
pushed a commit
to amcdnl/material2
that referenced
this pull request
Jul 8, 2017
…lar#5144) * fix(tooltip): remove native event listener on component destroy Component should clean up events it has registered to. Closes angular#4499 * Break at higher syntactic level * Undo accidental formatting
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component should clean up events it has registered to.
Closes #4499