Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input label, hint and placeholder colors don't follow material design spec #5114

Closed
gtranter opened this issue Jun 13, 2017 · 1 comment · Fixed by #5155
Closed

Input label, hint and placeholder colors don't follow material design spec #5114

gtranter opened this issue Jun 13, 2017 · 1 comment · Fixed by #5155
Assignees
@crisbeto
Labels
help wanted The team would appreciate a PR from the community to address this issue P4 A relatively minor issue that is not relevant to core functions

Comments

@gtranter
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

The label, placeholder, and hint text should be 54% black according to https://material.io/guidelines/components/text-fields.html#text-fields-states.

What is the current behavior?

They are currently 38% black from the 'hint-text' value of the light theme foreground palette.

What are the steps to reproduce?

https://material.angular.io/components/component/input

What is the use-case or motivation for changing an existing behavior?

Follow the guidelines properly. They look too faint.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

2.0.0-beta.6

Is there anything else we should know?
@jelbourn jelbourn added help wanted The team would appreciate a PR from the community to address this issue P4 A relatively minor issue that is not relevant to core functions labels Jun 14, 2017
@crisbeto crisbeto self-assigned this Jun 15, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 15, 2017
@crisbeto
fix(input,select): align colors with spec
b48825f 
* Aligns the colors in the select and input [themes based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states).
* Includes the changes from angular#4883 since the two PRs are closely connected.

Fixes angular#5114.
@crisbeto crisbeto mentioned this issue Jun 15, 2017
Merged
mmalerba pushed a commit that referenced this issue Jul 6, 2017
@crisbeto @mmalerba
fix(input,select): align colors with spec
016a159 
* Aligns the colors in the select and input [themes based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states).
* Includes the changes from #4883 since the two PRs are closely connected.

Fixes #5114.
jelbourn pushed a commit that referenced this issue Jul 14, 2017
@crisbeto @jelbourn
fix(input,select): align colors with spec
7f8af46 
* Aligns the colors in the select and input [themes based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states).
* Includes the changes from #4883 since the two PRs are closely connected.

Fixes #5114.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 15, 2017
@crisbeto
fix(input,select): align colors with spec
0ebe7f7 
* Aligns the colors in the select and input [themes based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states).
* Includes the changes from angular#4883 since the two PRs are closely connected.

Fixes angular#5114.
kara pushed a commit that referenced this issue Jul 21, 2017
@crisbeto @kara
fix(input,select): align colors with spec
448bc47 
* Aligns the colors in the select and input [themes based on the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states).
* Includes the changes from #4883 since the two PRs are closely connected.

Fixes #5114.
kara pushed a commit that referenced this issue Jul 21, 2017
@crisbeto @kara
fix(input,select): align colors with spec (#5155)
266f237 
Fixes #5114.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
help wanted The team would appreciate a PR from the community to address this issue P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(input,select): align colors with spec crisbeto/material2
3 participants
@jelbourn @crisbeto @gtranter