Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip): not rendering in IE and Edge without web animations polyfill #4937

Merged
merged 1 commit into from
Jun 5, 2017
Merged

fix(tooltip): not rendering in IE and Edge without web animations polyfill #4937

merged 1 commit into from
Jun 5, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 2, 2017

Fixes the tooltip not being rendered in IE and Edge, if there is no web animations polyfill. When we don't animate the element, for some reason IE and Edge decide not to lay it out at all. We force the element to be shown by using the zoom: 1 hack.

Fixes #4935.

@crisbeto
fix(tooltip): not rendering in IE and Edge without web animations pol…
e7a2354 
…yfill

Fixes the tooltip not being rendered in IE and Edge, if there is no web animations polyfill. When we don't animate the element, for some reason IE and Edge decide not to lay it out at all. We force the element to be shown by using the `zoom: 1` hack.

Fixes angular#4935.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 2, 2017
jelbourn
jelbourn approved these changes Jun 2, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 2, 2017
@andrewseguin andrewseguin merged commit 22746ce into angular:master Jun 5, 2017
@TomDemulierChevret TomDemulierChevret mentioned this pull request Jun 7, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IE11 tooltip doesn't work without web-animations
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin