fix(block-scroll-strategy): collapsing root node when enabled #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
scroll-block-width
branch
from
e27c799
to
68732c3
Compare
jelbourn
approved these changes
May 18, 2017
src/lib/core/overlay/_overlay.scss
Outdated
| // Necessary for iOS not to expand past the viewport. | ||
| max-width: 100vw; | ||
| // Necessary for the content not to lose its width. | ||
| width: 100%; |
There was a problem hiding this comment.
Add comment explaining why we use 100% instead of 100vh
* Prevents the `html` tag from collapsing when the `BlockScrollStrategy` is enabled. * Fixes the scroll strategy not being disabled properly in tests.
crisbeto
force-pushed
the
scroll-block-width
branch
from
68732c3
to
94657cc
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
htmltag from collapsing when theBlockScrollStrategyis enabled.Fixes #4646.