-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(checkbox, radio): Fix checkbox label not read in JAWS #4610
Conversation
e93576b
to
23b9054
Compare
Can you describe the problem this is fixing? According to the HTML spec, adding |
7b16d07
to
13b28f8
Compare
The problem is JAWS doesn't read the label for radio button or checkbox. Moving |
Can you reproduce the behavior on a simple html page with <label>
Active
<input type="checkbox">
</label> Or does it only happen w/ the material components? |
It only happen w/ the material components.
|
73d41a1
to
9f9aabf
Compare
9f9aabf
to
6a04753
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Along the same lines as angular#4610. Adds an extra element to allow for JAWS to pick up the label.
Along the same lines as #4610. Adds an extra element to allow for JAWS to pick up the label.
Along the same lines as #4610. Adds an extra element to allow for JAWS to pick up the label.
Along the same lines as #4610. Adds an extra element to allow for JAWS to pick up the label.
Along the same lines as angular#4610. Adds an extra element to allow for JAWS to pick up the label.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #3584 #3586