fix(radio): model should update before change event is fired #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
cla: yes
| /** Change event subscription set up by registerOnChange (ControlValueAccessor). */ | ||
| private _changeSubscription: {unsubscribe: () => any} = null; | ||
| /** The method to be called in order to update ngModel */ | ||
| private _onChangeHandler: (value: number) => void = (value) => {}; |
There was a problem hiding this comment.
What do you think of renaming this to _controlValueAccessorChangeFn? (similar for the touch one as well)
There was a problem hiding this comment.
- I have no idea where
numbercame from. - I'm for the rename - I was going to ask you to rename this for me since I had no idea what to call it.
|
@jelbourn rebased |
| @@ -273,6 +273,50 @@ describe('MdRadio', () => { | |||
| })); | |||
| }); | |||
|
|
|||
| describe('group with ngModel and change event', () => { | |||
There was a problem hiding this comment.
Why not use the existing "group with ngModel" block? You can just add a change event to the existing test component without affecting the other tests.
|
@jelbourn Addressed comments |
|
@jelbourn this is once again green and good to merge! |
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jelbourn
closes #448