Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

at MdInputContainer._isErrorState #4551

Closed
wahello opened this issue May 14, 2017 · 2 comments · Fixed by #4569
Closed

at MdInputContainer._isErrorState #4551

wahello opened this issue May 14, 2017 · 2 comments · Fixed by #4569
Assignees
@crisbeto

Comments

@wahello
Copy link

wahello commented May 14, 2017

at MdInputContainer._isErrorState (material.es5.js:15396)

ERROR TypeError: Cannot read property '_ngControl' of undefined
the code is here:
https://github.com/keyeMyria/bookingmanagement/tree/material2

and after run acess: http://localhost:4400/session/signin/
errors show.
@crisbeto crisbeto self-assigned this May 14, 2017
@crisbeto
Copy link
Member

@keyeMyria you're probably getting that error, because you haven't added mdInput on your inputs here: https://github.com/keyeMyria/bookingmanagement/blob/material2/src/app/session/signin/signin.component.html#L14. That being said, we should probably throw a better error beforehand.

crisbeto added a commit to crisbeto/material2 that referenced this issue May 15, 2017
@crisbeto
fix(input): continue checking for input child after initialization
92f5c1e 
Currently we only check if an `md-input-container` has a child upon initialization, however the child might be removed via `ngIf` at a later point. If that happens, we eventually run into some check that assumed that we have an input child, however it would be better if we threw the appropriate error. These changes add extra validation that ensure that the input continues to be in place after init.

Fixes angular#4551.
@crisbeto crisbeto mentioned this issue May 15, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue May 16, 2017
@crisbeto
fix(input): continue checking for input child after initialization
b0f4196 
Currently we only check if an `md-input-container` has a child upon initialization, however the child might be removed via `ngIf` at a later point. If that happens, we eventually run into some check that assumed that we have an input child, however it would be better if we threw the appropriate error. These changes add extra validation that ensure that the input continues to be in place after init.

Fixes angular#4551.
crisbeto added a commit to crisbeto/material2 that referenced this issue May 16, 2017
@crisbeto
fix(input): continue checking for input child after initialization
021b62d 
Currently we only check if an `md-input-container` has a child upon initialization, however the child might be removed via `ngIf` at a later point. If that happens, we eventually run into some check that assumed that we have an input child, however it would be better if we threw the appropriate error. These changes add extra validation that ensure that the input continues to be in place after init.

Fixes angular#4551.
jelbourn pushed a commit that referenced this issue May 17, 2017
@crisbeto @jelbourn
fix(input): continue checking for input child after initialization (#…
73d6814 
…4569)

Currently we only check if an `md-input-container` has a child upon initialization, however the child might be removed via `ngIf` at a later point. If that happens, we eventually run into some check that assumed that we have an input child, however it would be better if we threw the appropriate error. These changes add extra validation that ensure that the input continues to be in place after init.

Fixes #4551.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(input): continue checking for input child after initialization crisbeto/material2
2 participants
@wahello @crisbeto