fix(list-key-manager): remove handling for home and end keys #4544
Conversation
googlebot
added
the
cla: yes
|
I did a quick survey of Google Search, GMail, Drive, and this accessible autocomplete for US government web sites. For all of them, the home/end keys always apply to the text input no mater what state you're in. I think we should just follow this pattern, since it will be simpler and follow conventions. |
crisbeto
force-pushed
the
3496/list-key-manager-interactive
branch
from
d56e5d2
to
0083b9c
Compare
crisbeto
changed the title
|
Done @jelbourn. I removed it from the |
| let TAB_EVENT: KeyboardEvent; | ||
| let HOME_EVENT: KeyboardEvent; | ||
| let END_EVENT: KeyboardEvent; | ||
| let EVENTS: { |
There was a problem hiding this comment.
How about just fakeKeyEvents? It's not constant since you write the value in beforeEach.
crisbeto
force-pushed
the
3496/list-key-manager-interactive
branch
from
0083b9c
to
86229f4
Compare
crisbeto
added
action: merge
* Removes the handling for the home and end keys from the ListKeyManager since their usage isn't as generic as the arrow keys. * Adds the home and end key handling to the select specifically. * Reworks the Autocomplete, ListKeyManager and ChipList tests to use the `createKeyboardEvent`, instead of making their own fake keyboard events. * Adds a `target` parameter to the `createKeyboardEvent` function, allowing us to define the event target. Fixes angular#3496.
crisbeto
force-pushed
the
3496/list-key-manager-interactive
branch
from
86229f4
to
3cf0f7d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
createKeyboardEvent, instead of making their own fake keyboard events.targetparameter to thecreateKeyboardEventfunction, allowing us to define the event target.Fixes #3496.