fix(button): ripples blocking mouse events on user content #4526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The ripple overlay intercepts all mouse events on the user content and therefore users are not able to have interactive elements in their buttons. Normally buttons should not contain interactive elements inside, but since the fix is very easy it wouldn't hurt fixing it. * Removing the `(touchstart)` event that should prevent initial clicks because it didn't do anything (because of pointer-events: none) and the initial click doesn't seem to happen anymore. Related to angular#4503
googlebot
added
the
cla: yes
crisbeto
approved these changes
May 13, 2017
src/lib/button/button.scss
Outdated
| // Disable pointer events for the ripple container and focus overlay because the container | ||
| // will overlay the user content and we don't want to disable mouse events on the user content. | ||
| // Pointer events can be safely disabled because the ripple trigger element is the host element. | ||
| pointer-events: none; | ||
| } | ||
|
|
||
| // Overlay to be used as a tint. Note that the same effect can be achieved by using a pseudo |
There was a problem hiding this comment.
The comment here needs to be updated as well.
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ripple overlay intercepts all mouse events on the user content and therefore users are not able to have interactive elements in their buttons.
Normally buttons should not contain interactive elements inside, but since the fix is very easy it wouldn't hurt fixing it.
Removing the
(touchstart)event that should prevent initial clicks because it didn't do anything (because of pointer-events: none) and the initial click doesn'tseem to happen anymore.
Related to #4503