Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make input underline thick when in error state. #4506

Merged
merged 1 commit into from
May 15, 2017

Conversation

mmalerba
Copy link
Contributor

also add underline ripple effect from the mocks

demo: https://mmalerba-demo1.firebaseapp.com/input

fixes #3490

@mmalerba mmalerba requested a review from jelbourn May 12, 2017 17:47
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 12, 2017
also add underline ripple effect from the mocks
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 12, 2017
@willshowell
Copy link
Contributor

Shouldn't it also be thicker under hover too?

screen shot 2017-05-12 at 2 39 48 pm

And maybe it isn't as high of a priority and could be done later, but it looks like switching to error state should also trigger a ripple. Seen here

@jelbourn jelbourn merged commit 0666207 into angular:master May 15, 2017
@mmalerba mmalerba deleted the input-under branch April 3, 2018 15:17
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid ("error") underline on form inputs should be 2px thick even when not focused
4 participants