Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(focus-origin): missing rxjs of operator #4497

Merged
merged 1 commit into from
May 15, 2017

Conversation

devversion
Copy link
Member

Recently in SHA f27df86 the Observable.of operator has been introduced. This operator hasn't been imported explicitly.

The build doesn't fail if the whole library is built together because other files import the operator.

But when compiling the core/ package on its own it will start failing.

Recently in SHA f27df86 the `Observable.of` operator has been introduced. This operator hasn't been imported explicitly.

The build doesn't fail if the whole library is built together because other files import the operator.

But when compiling the `core/` package on its own it will start failing.
@devversion devversion requested a review from jelbourn May 12, 2017 13:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 12, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 12, 2017
@jelbourn jelbourn merged commit 05dbb90 into angular:master May 15, 2017
@devversion devversion deleted the fix/focus-orgin-of-rxjs branch November 11, 2017 10:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants