Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tabs): allow disabling ripples #4466

Merged
merged 1 commit into from
May 10, 2017
Merged

feat(tabs): allow disabling ripples #4466

merged 1 commit into from
May 10, 2017

Conversation

devversion
Copy link
Member

  • Adds the possibility to disable ripples for tab-groups.

Avoids ugly workarounds like in AIO: angular/angular@ce57b6f

@devversion
feat(tabs): allow disabling ripples
d1afc95 
* Adds the possibility to disable ripples for tab-groups.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 10, 2017
andrewseguin
andrewseguin approved these changes May 10, 2017
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 10, 2017
@kara kara merged commit e4789c7 into angular:master May 10, 2017
@devversion devversion deleted the feat/tabs-disable-ripple branch November 11, 2017 10:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @andrewseguin @kara @googlebot